Fix default resampling quality selection #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farshield
changed the title
farshield
changed the title
When the user doesn't explicitly specify the resampling quality using the `-Q` flag, the quality should be calculated based on Jack's server sampling rate. This isn't the case, because the `rqual` variable is always set to 16 in `jack_initialize`. This results in the quality always being 16. To fix this and make the behavior the same as the `zita-ajbridge` tools, the redundant `rqual` clamping of the value to the range `[16,96]` should be removed from `jack_initialize()`, because this is done later in `jack_initialize_part2()` only AFTER the quality calculation.
farshield
force-pushed
the
fix-default-quality
branch
from
31435ff to
87fca05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user doesn't explicitly specify the resampling quality using the
-Qflag, the quality should be calculated based on Jack's server sampling rate.This isn't the case, because the
rqualvariable is always set to 16 injack_initialize. This results in the quality always being 16.To fix this and make the behavior the same as the
zita-ajbridgetools, the redundantrqualclamping of the value to the range[16,96]should be removed fromjack_initialize(), because this is done later injack_initialize_part2()only AFTER the quality calculation.