Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FLAC and WAV Audio Support #92

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Conversation

Zidiam
Copy link
Contributor

@Zidiam Zidiam commented Jan 13, 2025

This merge request updates Asphalt to recognize and upload .flac and .wav audio files, alongside existing formats (.mp3 and .ogg). Notable changes include:

  • New Audio Variants: Added Flac and Wav to AudioKind and mapped them to corresponding CloudAssetType entries (AudioFlac and AudioWav) for the upload flow.
  • Cargo Dependencies: Bumped rbxcloud from 0.14.0 to 0.15.1 in Cargo.toml, ensuring compatibility with the updated audio types.
  • Asset Pipeline: Adjusted Asset::new to recognize .flac and .wav as valid file extensions for audio uploads, removing the need to manually convert these formats.

With these changes, .flac and .wav files can now be uploaded as high-fidelity audio assets without encountering “unknown extension” errors.

@Zidiam
Copy link
Contributor Author

Zidiam commented Jan 13, 2025

Thanks for the fixes!

@jackTabsCode jackTabsCode merged commit 1e711ce into jackTabsCode:main Jan 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants