fixup! WIP: Refactor env and executions

jaceksan · Feb 2, 2024 · 4696c2a · 4696c2a
1 parent abf522a
commit 4696c2a
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 9 deletions.
diff --git a/.github/workflows/elta_dev.yml b/.github/workflows/elta_dev.yml
@@ -44,7 +44,8 @@ jobs:
     uses: ./.github/workflows/reusable_read_env.yml
 
   build-images:
-    needs: read-env
+    needs:
+     - read-env
     uses: ./.github/workflows/reusable_builds.yml
     with:
       MELTANO_CUSTOM_IMAGE: "${{ needs.read-env.outputs.MELTANO_CUSTOM_IMAGE }}"

diff --git a/.github/workflows/reusable_read_env.yml b/.github/workflows/reusable_read_env.yml
@@ -2,25 +2,34 @@ on:
   workflow_call:
     outputs:
       MELTANO_VERSION:
-        value: ${{ jobs.reusable-read-env.steps.vars.outputs.MELTANO_VERSION }}
+        value: ${{ jobs.reusable-read-env.outputs.MELTANO_VERSION }}
       DBT_VERSION:
-        value: ${{ jobs.reusable-read-env.steps.vars.outputs.DBT_VERSION }}
+        value: ${{ jobs.reusable-read-env.outputs.DBT_VERSION }}
       GOODDATA_VERSION:
-        value: ${{ jobs.reusable-read-env.steps.vars.outputs.GOODDATA_VERSION }}
+        value: ${{ jobs.reusable-read-env.outputs.GOODDATA_VERSION }}
       PYTHON_IMAGE:
-        value: ${{ jobs.reusable-read-env.steps.vars.outputs.PYTHON_IMAGE }}
+        value: ${{ jobs.reusable-read-env.outputs.PYTHON_IMAGE }}
       IMAGES_WORKDIR:
-        value: ${{ jobs.reusable-read-env.steps.vars.outputs.IMAGES_WORKDIR }}
+        value: ${{ jobs.reusable-read-env.outputs.IMAGES_WORKDIR }}
       MELTANO_CUSTOM_IMAGE:
-        value: ${{ jobs.reusable-read-env.steps.vars.outputs.MELTANO_CUSTOM_IMAGE }}
+        value: ${{ jobs.reusable-read-env.outputs.MELTANO_CUSTOM_IMAGE }}
       DBT_CUSTOM_IMAGE:
-        value: ${{ jobs.reusable-read-env.steps.vars.outputs.DBT_CUSTOM_IMAGE }}
+        value: ${{ jobs.reusable-read-env.outputs.DBT_CUSTOM_IMAGE }}
       GOODDATA_CUSTOM_IMAGE:
-        value: ${{ jobs.reusable-read-env.steps.vars.outputs.GOODDATA_CUSTOM_IMAGE }}
+        value: ${{ jobs.reusable-read-env.outputs.GOODDATA_CUSTOM_IMAGE }}
 
 jobs:
   reusable-read-env:
     runs-on: ubuntu-latest
+    outputs:
+      MELTANO_VERSION: ${{ steps.vars.outputs.MELTANO_VERSION }}
+      DBT_VERSION: ${{ steps.vars.outputs.DBT_VERSION }}
+      GOODDATA_VERSION: ${{ steps.vars.outputs.GOODDATA_VERSION }}
+      PYTHON_IMAGE: ${{ steps.vars.outputs.PYTHON_IMAGE }}
+      IMAGES_WORKDIR: ${{ steps.vars.outputs.IMAGES_WORKDIR }}
+      MELTANO_CUSTOM_IMAGE: ${{ steps.vars.outputs.MELTANO_CUSTOM_IMAGE }}
+      DBT_CUSTOM_IMAGE: ${{ steps.vars.outputs.DBT_CUSTOM_IMAGE }}
+      GOODDATA_CUSTOM_IMAGE: ${{ steps.vars.outputs.GOODDATA_CUSTOM_IMAGE }}
     steps:
       - name: Checkout Repository
         uses: actions/checkout@v4