fix: Find project for existing key correctly #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error would always be returned if the first entry in the project list wasn't the one we were looking for. Instead, check all entries, then error if it wasn't found
|
I don't know if you have automatic releasing setup, but if you're happy with this and you merge, I'd appreciate a new tagged release, I'm hoping to use this project :) |
jace-ys
approved these changes
Dec 8, 2020
|
Hi @mikebryant! Thanks for raising this issue and fix, I can confirm I can reproduce the issue you're seeing (: What a silly mistake from me 🤦 I am happy to get this merged, and I shall tag a new release (automated release is setup)! 🎉 |
|
Thank you for the quick response! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error would always be returned if the first entry in the project list wasn't the one we were looking for. Instead, check all entries, then error if it wasn't found
Fixes #1
Additional context