Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/timestamp #7

Merged
merged 10 commits into from
Sep 27, 2023
Merged

Feature/timestamp #7

merged 10 commits into from
Sep 27, 2023

Conversation

agistyaanugrah
Copy link
Contributor

Finish feature timestamp v.1

datasae/timestamp.py Outdated Show resolved Hide resolved
pipinfitriadi

This comment was marked as resolved.

@pipinfitriadi pipinfitriadi marked this pull request as draft September 27, 2023 07:02
Copy link
Member

@pipinfitriadi pipinfitriadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 unittest masih failed kang @fauzanmr, minta tolong diperbaiki dulu

https://github.com/jabardigitalservice/DataSae/actions/runs/6320473278/job/17163025627?pr=7

overall issue pull requests nya unittest failed dan style

tests/test_timestamp.py Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 27, 2023

Coverage report

Note

Coverage evolution disabled because this PR targets a different branch
than the default branch, for which coverage data is not available.

The coverage rate is 100%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

datasae/timestamp.py

100% of new lines are covered (100% of the complete file).

tests/test_timestamp.py

100% of new lines are covered (100% of the complete file).

Copy link
Member

@pipinfitriadi pipinfitriadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pipinfitriadi pipinfitriadi marked this pull request as ready for review September 27, 2023 08:34
Copy link
Member

@pipinfitriadi pipinfitriadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done

@pipinfitriadi pipinfitriadi merged commit ba2bde8 into develop Sep 27, 2023
13 checks passed
@pipinfitriadi pipinfitriadi deleted the feature/timestamp branch September 27, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants