New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/config converter spreadsheet #13

Merged

pipinfitriadi merged 21 commits into release/0.3.0 from feature/config_converter_spreadsheet

Oct 30, 2023

Contributor

hanieffatchudin commented Oct 30, 2023

No description provided.

hanieffatchudin and others added 20 commits

October 20, 2023 10:37


          feat: pembuatan connector sreadsheet


          Merge branch 'feature/config_converter_spreadsheet' of https://github…

b12cc8e

….com/jabardigitalservice/DataSae into feature/config_converter_spreadsheet


          Merge branch 'release/0.3.0' into feature/config_converter_spreadsheet

435b507


          feat: develop converter google spreadsheet

3d7ea69


          Update README.md

5f46e2e

add test spreadsheet


          feat : Perapihan codingan


          feat: delete #creds.json

38d50e0


          feat: ganti link creads.json

fafc03b


          fix: rename google spreadsheet into gsheet

b9d3f2f


          fix: add missing depedency for gsheet

6ef65b8


          fix: add DataFrameTestCase for reuse

7a4773e


          fix: change creds path for gsheet config

eda3be9


          fix: ignore gsheet converter

dea4719

Ref: https://github.com/burnash/gspread/blob/933fc1b8e6f6b52bddc760d4c38b3b4ab16ad196/gspread/auth.py#L63-L66


          fix: Converter gsheet remove unused service from connection

935dce4


          fix: converter s3 and it's unittest

9c148c9


          fix: Converter gsheet simplify connection code

df453b1


          feat: Implementasi unittest converter gsheet

ad99797


          fix: test converter gsheet

ee93d16

Simplification logic on csv to list dict


          fix: test converter gsheet

29d18db

Simplification logic on csv to list dict


          docs: update README.md

7d988f3

config.json and config.yaml

hanieffatchudin added the enhancement label

hanieffatchudin requested a review from pipinfitriadi

October 30, 2023 05:03

hanieffatchudin assigned pipinfitriadi and hanieffatchudin

github-actions bot commented Oct 30, 2023 •

edited

Loading

Coverage report

Note

Coverage evolution disabled because this PR targets a different branch
than the default branch, for which coverage data is not available.

The coverage rate is 100%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

datasae/converter/init.py

100% of new lines are covered (100% of the complete file).

datasae/converter/gsheet.py

100% of new lines are covered (100% of the complete file).

datasae/converter/s3.py

100% of new lines are covered (100% of the complete file).

tests/test_converter/init.py

100% of new lines are covered (100% of the complete file).

tests/test_converter/test_gsheet.py

100% of new lines are covered (100% of the complete file).

tests/test_converter/test_s3.py

100% of new lines are covered (100% of the complete file).


          fix: resimplify code for converter __call__ method

490cc7d

pipinfitriadi approved these changes

View reviewed changes

pipinfitriadi merged commit 0a6ad73 into release/0.3.0

11 checks passed

pipinfitriadi deleted the feature/config_converter_spreadsheet branch

October 30, 2023 05:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels