Merge pull request civicrm#16862 from eileenmcnaughton/build

[REF] Remove redundant call to build permissions
jaapjansma · Mar 20, 2020 · 4fefe75 · 4fefe75
2 parents 1bb6e83 + 89af342
commit 4fefe75
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/CRM/Report/Form.php b/CRM/Report/Form.php
@@ -3870,6 +3870,9 @@ public function whereMembershipTypeClause($value, $op) {
    * Buld contact acl clause
    * @deprecated in favor of buildPermissionClause
    *
+   * Note that if the buildPermissionClause function is called (which most reports do from
+   * buildQuery then the results of this function are re-calculated and overwritten.
+   *
    * @param string $tableAlias
    */
   public function buildACLClause($tableAlias = 'contact_a') {

diff --git a/CRM/Report/Form/Contribute/Summary.php b/CRM/Report/Form/Contribute/Summary.php
@@ -741,14 +741,6 @@ public function statistics(&$rows) {
     return $statistics;
   }
 
-  /**
-   * Post process function.
-   */
-  public function postProcess() {
-    $this->buildACLClause($this->_aliases['civicrm_contact']);
-    parent::postProcess();
-  }
-
   /**
    * Build chart.
    *