Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL Support #4

Merged
merged 3 commits into from
Jun 27, 2013
Merged

SSL Support #4

merged 3 commits into from
Jun 27, 2013

Conversation

cjsaylor
Copy link
Contributor

This patch adds SSL support in two different fashions:

  1. No SSL verification: connect and transmit encrypted with no verification check from the host that this sender is authorized. In this case, the user would only specify ssl_enable: true.
  2. SSL Verification: Challenged during connection that the public certificate is acceptable from logstash's configured CA Cert(s). In this case, the user would enable SSL and also specify the client's certificate and private key to establish the SSL connection. The certificate would need to be installed on the logstash server to verify the sender as trusted.

I've also added some general configuration documentation under the /docs directory which is created to hold any future documentation.

Since the test certificates and keys are self-signed, I had to update the travis configuration to set the NODE_TLS_REJECT_UNAUTHORIZED=0, as node by default will reject self-signed certificates. This also means this environment variable needs to be set prior to running npm test locally, which I've updated in the readme.

Includes:
* SSL verification if the logstash is configured to verify the sender.
This is tested by passing the public key of the client as a CA to the
SSL TPC server.
jaakkos added a commit that referenced this pull request Jun 27, 2013
@jaakkos jaakkos merged commit 2ccd997 into jaakkos:master Jun 27, 2013
@jaakkos
Copy link
Owner

jaakkos commented Jun 27, 2013

Thanks for great contribution. 👍
I'll push new version to npm.

@jaakkos
Copy link
Owner

jaakkos commented Jun 27, 2013

Pushed to npm https://npmjs.org/package/winston-logstash

@cjsaylor cjsaylor deleted the ssl-support branch June 27, 2013 10:52
@cjsaylor
Copy link
Contributor Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants