Logs sent to logstash are interpreted as stream and therefore are incorrectly parsed #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sh server interprets as a complete log message.
jaakkos
added a commit
that referenced
this pull request
May 23, 2013
Logs sent to logstash are interpreted as stream and therefore are incorrectly parsed
|
Thanks! |
br0p0p
added a commit
to br0p0p/winston-logstash
that referenced
this pull request
Jun 4, 2019
Winston 3 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the socket is not sending a new line with each log message the Logstash server (1.1.12) interpret it as incomplete. This results in all logs sent being interpreted as a single entry when the socket closes.
Fixed by adding a new line to the end of the message to ensure that the logstash server interprets as a complete log message.
I've updated the tests to reflect this. It might be that previous versions of Logstash server do not have this requirement.