Remove winston dependency #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, winston-logstash would install a version of winston into node_modules/winston-logstash/node_modules/winston. If node chooses to use this version of winston rather than the cached version from node_modules/winston, the consuming application's winston would not have the Logstash transport attached to it. This fix removes winston as a dependency, and it is assumed that winston must be installed by the consumer.
|
I also suppose peerDependencies would also work in this situation. |
|
👍 |
|
I added winston back as a peer dependency. If you approve, could you merge it and release to npm? |
|
Thanks, I have been offline during holidays :) |
|
Published new version https://npmjs.org/package/winston-logstash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, winston-logstash would install a version of winston into
node_modules/winston-logstash/node_modules/winston. If node chooses touse this version of winston rather than the cached version from
node_modules/winston, the consuming application's winston would not havethe Logstash transport attached to it.
This fix removes winston as a dependency, and it is assumed that winston
must be installed by the consumer.