Skip to content

Commit

Permalink
Adding a new line to the end of the message to ensure that the logsta…
Browse files Browse the repository at this point in the history
…sh server interprets as a complete log message.
  • Loading branch information
gwhitelaw committed May 23, 2013
1 parent d4d5875 commit ae9ff56
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/winston-logstash.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ Logstash.prototype.sendLog = function (message, callback) {
var self = this;
callback = callback || function () {};

self.socket.write(message);
self.socket.write(message + '\n');
callback();
};

Expand Down
18 changes: 16 additions & 2 deletions test/winston-logstash_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,27 @@ describe('winston-logstash transport', function() {
done();
});

it('send logs over TCP', function(done) {
it('send logs over TCP as valid json', function(done) {
var response;
var logger = createLogger(port);
var expected = {"stream":"sample","level":"info","message":"hello world"};

test_server = createTestServer(port, function (data) {
response = data.toString();
expect(response).to.be.equal('{"stream":"sample","level":"info","message":"hello world"}');
expect(JSON.parse(response)).to.be.eql(expected);
done();
});

logger.log('info', 'hello world', {stream: 'sample'});
});

it('send each log with a new line character', function(done) {
var response;
var logger = createLogger(port);

test_server = createTestServer(port, function (data) {
response = data.toString();
expect(response).to.be.equal('{"stream":"sample","level":"info","message":"hello world"}\n');
done();
});

Expand Down

0 comments on commit ae9ff56

Please sign in to comment.