Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/java21 code cleanup #573

Merged
merged 11 commits into from
Mar 10, 2024
Merged

Feature/java21 code cleanup #573

merged 11 commits into from
Mar 10, 2024

Conversation

tonihele
Copy link
Contributor

@tonihele tonihele commented Mar 2, 2024

Let #572 go first as this branch is based on that one. Here should be only some code cleanups.

Also this Thread.stop() is managed here.

@tonihele
Copy link
Contributor Author

tonihele commented Mar 2, 2024

Now it looks a bit more sensible

@tonihele
Copy link
Contributor Author

tonihele commented Mar 9, 2024

I'll merge in 24h if no objections arise

neph1
neph1 approved these changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@neph1 neph1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't check every change, but looks all right! 💯

@tonihele tonihele merged commit 2789836 into jMonkeyEngine:master Mar 10, 2024
1 check passed
@tonihele tonihele deleted the feature/java21-code-cleanup branch March 10, 2024 21:04
@neph1 neph1 added this to the 3.7 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neph1 neph1 neph1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7
Development

Successfully merging this pull request may close these issues.
2 participants
@tonihele @neph1