Fix #463 by allowing other texture settings and only changing Flip an… #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nging Flip and Repeat
neph1
commented
Feb 6, 2023
| @@ -54,7 +54,8 @@ public void run() { | |||
| if (texPreview == null) { | |||
| texPreview = new TexturePreview(manager); | |||
| } | |||
| texPreview.requestPreview(stripQuotes(textureName), "", 80, 25, texturePreview, null); | |||
| final String[] textureNameComponents = textureName.split(" "); | |||
| texPreview.requestPreview(stripQuotes(textureNameComponents[textureNameComponents.length-1]), "", 80, 25, texturePreview, null); | |||
There was a problem hiding this comment.
Split and take last segment to get actual texture name
neph1
commented
Feb 6, 2023
| } | ||
| propertyValue += textureName; | ||
| property.setValue(propertyValue); | ||
| texturePreview.setToolTipText(propertyValue); |
There was a problem hiding this comment.
Don't replace whole line, just modify Flip and Repeat, if they exist
neph1
commented
Feb 6, 2023
| } | ||
| property.setValue(textureName); |
|
The following tests have been performed:
If someone wants to test this themselves, please do. Otherwise I'll merge this after an unspecified amount of time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d Repeat
This is a preliminary fix. Not ready to merge yet.
I'd like a second set of eyes before merging.
So the cause was that all those "new" settings have never been implemented in the Material Editor.
Implementing all those is an undertaking I'm not ready to do right now. So my proposed interim solution is to not care about other settings than "Flip" and "Repeat", but not overwrite them either. This allows advanced users to keep modifying their materials in the Material Editor (but preview might be wrong? I'm not familiar with the settings).
Edit: Still need to update TexturePanelSquare. Only used in shader editor, I think