build.gradle: use get() to convert Jar-task properties to strings #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephengold
added
defect
8Keep
approved these changes
Dec 5, 2024
|
Followup, make this task and any others missing run on CI |
It seems best to do that as part of this PR. I moved the "createZipDistribution" task in the "BuildJMonkey" job, from the deployment if-block to the section that runs across the entire 3x3 matrix. Since "createZipDistrbution" depends on the "libDist" task, that provides the desired test coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are meant to resolve issue #2335.
The
archiveClassiferandarchiveExtensionproperties ofarchiveTaskare converted to strings usingget().This enables the correct JAR files to be copied to the correct "build/libDist" folders under the correct names.
Tested on both Linux and Windows. Holding 24 hours for review. If there's no substantial discussion, I will self-integrate this PR.