-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gradle wrapper to 8.8 #2288
Conversation
43edae5
to
19df0e2
Compare
Did you follow the documented update procedure? |
I didn't read the whole doc, most of it is irrelevant to us, but yeah that's pretty much what I did. |
Running
Please include those change in this PR. |
I've reviewed the changes and don't see any problems. However, a change like this needs thorough testing more than it needs human review. I'm curious how much testing has been done so far:
|
@8Keep I remain curious. |
Let me try these later today. We should also run these in CI, I'm surprised that we don't already. |
@stephengold I've ran all the tasks you've sent, except release, because that doesn't exist. Unless you meant publish, which I can't finish due to not having a key. publishToMavenLocal does succeed. copyLibs needed an update on line 117 of build.gradle. The thing is that according to some online sources, this was changed with gradle 7, so it may not have worked ever since the gradle 7 upgrade was done. |
Good progress, thank you.
You're right: I was thinking of the publish tasks. Since "publishToMavenLocal" succeeded, there's a high probability that "publishMavenPublicationToSNAPSHOTRepository" and "publishMavenPublicationToOSSRHRepository" will also work. I think this PR is ready for integration into the "master" branch. Do you agree? |
Yes, I agree. I want to do some followups, but I'll start these in separate prs:
|
It looks like publishing natives did fail once it was committed. Stephen, do you know what the implications of this error are: https://github.com/jMonkeyEngine/jmonkeyengine/actions/runs/9820622481/job/27115496415#step:5:549 |
I think it's related to a change at Sonatype. On 11 June, I got a cryptic e-mail from them about updating our plugin settings. Maybe those changes took effect sometime between 3 July and now? I've generated Sonatype user tokens before, for my personal repos. I don't want to do it tonight when I'm tired. I'll investigate further tomorrow when I'm fresh. |
And now I see the CI for 5248fb0 succeeded, so perhaps it was just a transient network error. Let's wait and see whether it recurs. |
I believe this was the change that caused issue #2335 |
Fix #2287