Gradle build (zip) #2235
Merged
Gradle build (zip) #2235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scenemax3d
reviewed
Mar 26, 2024
jme3-lwjgl3/src/main/java/com/jme3/system/lwjgl/LwjglCanvas.java
Outdated
Show resolved
Hide resolved
scenemax3d
reviewed
Mar 26, 2024
This reverts commit 1eba882.
stephengold
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Looks good to me.
Although I want to encourage developers to use jme3-lwjgl3 instead of jme3-lwjgl, the jme3-examples app chooser still works better with jme3-lwjgl. This PR reverts the unintended change to jme3-examples and the dist JAR that was included in PR #2153.
Meanwhile, we should also discourage people from relying the dist JAR (at GitHub) to obtain JME libraries and dependencies, since it doesn't include all of them. People should download JME libraries and dependencies from Maven Central instead, preferably using Gradle build scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
This PR resolves dependency issues with lwjgl (2 or 3) reported on the forum when trying to use the zip version of JME3.
The reason for these problems is that jme3-lwjgl3 only loaded the dependencies at runtime and when compiling JME3 it did not export the jar files, this can be solved by changing the way of adding the dependencies:
api "org.lwjgl:lwjgl:${lwjgl3Version}:natives-windows"Should we use jme3-lwjgl3 by default in the examples? (I think it's already quite stable)