Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CompositeAppState.java #2193

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

scenemax3d
Copy link
Contributor

For complex game state management, JME users can benefit from having a composite app state which handles child app states. This way the developer can easily organize his game states.

This composite app state is a contribution of Paul Speed and was copied as-is from:
src/main/java/com/simsilica/state/CompositeAppState.java

@scenemax3d scenemax3d added this to the v3.7.0 milestone Feb 7, 2024
@scenemax3d scenemax3d requested a review from pspeed42 February 7, 2024 08:13
@scenemax3d
Copy link
Contributor Author

Hi @pspeed42,
Can you please review the license text and add whatever needed credit / reference to your SiO2 lib

Thanks again :)

@pspeed42
Copy link
Contributor

pspeed42 commented Feb 7, 2024

To cover all bases, it might be nice to add a line like:
"Copied with Paul Speed's permission from: https://github.com/Simsilica/SiO2"
...somewhere near the copyright (maybe right before the all rights reserved).
It makes the pedigree clear and the permission explicit.
But it's technically fine as-is.

update license text
@scenemax3d
Copy link
Contributor Author

To cover all bases, it might be nice to add a line like: "Copied with Paul Speed's permission from: https://github.com/Simsilica/SiO2" ...somewhere near the copyright (maybe right before the all rights reserved). It makes the pedigree clear and the permission explicit. But it's technically fine as-is.

Sure! done.

@scenemax3d scenemax3d merged commit 53994eb into jMonkeyEngine:master Feb 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants