Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PBR Support for Glow #2162

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Conversation

codex128
Copy link
Contributor

@codex128 codex128 commented Dec 19, 2023

Fixes #2161 by making PBRLighting use PBRGlow.frag, which uses Emissive and EmissiveMap material parameters for calculating glow.

@stephengold stephengold merged commit 04da08f into jMonkeyEngine:master Dec 31, 2023
14 checks passed
@stephengold stephengold added this to the Future Release milestone Dec 31, 2023
@scenemax3d scenemax3d modified the milestones: Future Release, v3.7.0 Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PBRLighting incompatible with Glow.frag
3 participants