Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javadoc indicates wrong default for Armature.setModelTransformClass() #2142

Closed
stephengold opened this issue Nov 8, 2023 · 1 comment · Fixed by #2154 or #2315
Closed

javadoc indicates wrong default for Armature.setModelTransformClass() #2142

stephengold opened this issue Nov 8, 2023 · 1 comment · Fixed by #2154 or #2315
Labels
Documentation Issues that affect the Wiki, Javadoc or any other form of documentation
Milestone

Comments

@stephengold
Copy link
Member

The javadoc says the default is MatrixJointModelTransform:

/**
* Sets the JointModelTransform implementation
* Default is {@link MatrixJointModelTransform}
*
* @param modelTransformClass which implementation to use
* @see JointModelTransform
* @see MatrixJointModelTransform
* @see SeparateJointModelTransform
*/
public void setModelTransformClass(Class<? extends JointModelTransform> modelTransformClass) {

The actual default is SeparateJointModelTransform:

private Class<? extends JointModelTransform> modelTransformClass = SeparateJointModelTransform.class;

@stephengold stephengold added the Documentation Issues that affect the Wiki, Javadoc or any other form of documentation label Nov 8, 2023
@stephengold stephengold added this to the Future Release milestone Nov 8, 2023
@stephengold stephengold reopened this Oct 22, 2024
@stephengold
Copy link
Member Author

Apparently PR #2154 didn't get properly integrated. I'll submit a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues that affect the Wiki, Javadoc or any other form of documentation
Projects
None yet
2 participants