Added a method and validation for PostgreSQL 8.* compatibility #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a method and validation for PostgreSQL 8.* compatibility using the same fields and values from the last insert as filters. PostgreSQL 8.* doesn't have a RETURNING keyword. The validation checks the current server version so we can skip this fix if we're using PostgreSQL 9+.
|
This feature has been discussed at length previously and a decision was taken to only support
Please see the discussion at #89 and #62 for more information on this decision. Unfortunately for reasons already mentioned I will not be merging this pull request. Thank you for taking the time to prepare it and for your interest in Idiorm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a method and validation for PostgreSQL 8.* compatibility using the same fields and values from the last insert as filters. PostgreSQL 8.* doesn't have a RETURNING keyword.
The validation checks the current server version so we can skip this fix if we're using PostgreSQL 9+.