Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default values for parameters after optional parameters #345

Closed
wants to merge 1 commit into from
Closed

Add default values for parameters after optional parameters #345

wants to merge 1 commit into from

Conversation

tacman
Copy link
Contributor

@tacman tacman commented Mar 15, 2024

Fixes #344

Not sure that $type can be null, but this at least gets rid of the deprecation errors.

jtojnar
jtojnar requested changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$logMessage and $type should not become nullable since they are concatenated to strings.

AFAICT, the $node arguments are always passed so we should remove the default there.

@tacman
Copy link
Contributor Author

tacman commented Mar 15, 2024

Makes sense. Should I close this PR and submit a new one with $node as a required parameter?

@jtojnar
Copy link
Collaborator

jtojnar commented Mar 15, 2024 via email

@jtojnar
Copy link
Collaborator

jtojnar commented Mar 15, 2024

Superseded by #347

@jtojnar jtojnar closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional Parameters can only come after required in PHP 8
2 participants
@tacman @jtojnar