Ensure find_string & replace_string size are equal
#281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That validation is performed in `parseLines` so the size of them can't mismatch when merging configuration for example. A warning log is raised in case of mismatch.
jtojnar
reviewed
Jan 7, 2022
Comment on lines
+414
to
+415
| $config->find_string = []; | ||
| $config->replace_string = []; |
There was a problem hiding this comment.
Maybe we could zip them together (i.e. trim them to the length of the shorter)?
There was a problem hiding this comment.
Won't we have undesired side effects?
In that case, it'll work
find_string: badstuff
replace_string: goodone
replace_string: src="
In that case, it'll not work because you'll replace hellow by goodone if you zip them.
find_string: hellow
find_string: badstuff
replace_string: goodone
I think it's preferable to empty them and log a warning to the user instead.
There was a problem hiding this comment.
Either way sounds reasonable to me.
jtojnar
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That validation is performed in
parseLinesso the size of them can't mismatch when merging configuration for example.A warning log is raised in case of mismatch.
Following #279 (comment)
Poke @jtojnar