Merge pull request #48 from izumin5210/izumin5210/parallel-build

Build tools in parallel

cmd/gex/errors_go112.go

@@ -0,0 +1,14 @@
+// +build !go1.13
+
+package main
+
+import (
+	"github.com/izumin5210/gex/pkg/tool"
+)
+
+func asBuildErrors(err error) *tool.BuildErrors {
+	if errs, ok := err.(*tool.BuildErrors); ok {
+		return errs
+	}
+	return nil
+}

cmd/gex/errors_go113.go

@@ -0,0 +1,17 @@
+// +build go1.13
+
+package main
+
+import (
+	"errors"
+
+	"github.com/izumin5210/gex/pkg/tool"
+)
+
+func asBuildErrors(err error) *tool.BuildErrors {
+	var errs *tool.BuildErrors
+	if errors.As(err, &errs) {
+		return errs
+	}
+	return nil
+}

cmd/gex/main.go

@@ -75,6 +75,13 @@ func run() error {
 		printHelp(os.Stdout)
 	case flagBuild:
 		err = toolRepo.BuildAll(ctx)
+		if errs := asBuildErrors(err); errs != nil {
+			for _, err := range errs.Errs {
+				fmt.Fprintln(os.Stdout, err.Error())
+			}
+			return errors.New("failed to build tools")
+		}
+		return err
 	case flagInit:
 		err = toolRepo.Add(ctx, "github.com/izumin5210/gex/cmd/gex")
 	case flagRegen:

pkg/tool/errors.go

@@ -0,0 +1,55 @@
+package tool
+
+import (
+	"fmt"
+	"strings"
+	"sync"
+)
+
+type BuildError struct {
+	Tool Tool
+	Err  error
+}
+
+func (e *BuildError) Unwrap() error { return e.Err }
+
+func (e *BuildError) Error() string {
+	return fmt.Sprintf("failed to build %s: %s", e.Tool.Name(), e.Err)
+}
+
+type BuildErrors struct {
+	sync.RWMutex
+	Errs []*BuildError
+}
+
+func (e *BuildErrors) Unwrap() error {
+	e.RLock()
+	defer e.RUnlock()
+
+	return e.Errs[0]
+}
+
+func (e *BuildErrors) Error() string {
+	e.RLock()
+	defer e.RUnlock()
+
+	var b strings.Builder
+	b.WriteString("failed to build ")
+	b.WriteString(e.Errs[0].Tool.Name())
+	if n := len(e.Errs); n > 1 {
+		b.WriteString(fmt.Sprintf(" (and %d tool(s))", n))
+	}
+	b.WriteString(": ")
+	b.WriteString(e.Errs[0].Err.Error())
+	return b.String()
+}
+
+func (e *BuildErrors) Append(t Tool, err error) {
+	e.Lock()
+	defer e.Unlock()
+	e.Errs = append(e.Errs, &BuildError{Tool: t, Err: err})
+}
+
+func (e *BuildErrors) Empty() bool {
+	return len(e.Errs) == 0
+}

pkg/tool/repository.go

@@ -3,6 +3,7 @@ package tool
 import (
 	"context"
 	"strings"
+	"sync"
 
 	"github.com/pkg/errors"
 
@@ -116,11 +117,27 @@ func (r *repositoryImpl) BuildAll(ctx context.Context) error {
 		return errors.WithStack(err)
 	}
 
+	var (
+		wg   sync.WaitGroup
+		errs BuildErrors
+	)
+
 	for _, t := range m.Tools() {
-		_, err = r.Build(ctx, t)
-		if err != nil {
-			return errors.WithStack(err)
-		}
+		t := t
+		wg.Add(1)
+		go func() {
+			defer wg.Done()
+			_, err = r.Build(ctx, t)
+			if err != nil {
+				errs.Append(t, err)
+			}
+		}()
+	}
+
+	wg.Wait()
+
+	if !errs.Empty() {
+		return &errs
 	}
 
 	return nil