src/sparse: Fix supernodal sptrsv build with LayoutRight=ON

[e10harvey]

Sorry for the formatting changes; I can back those out if you'd like. My pre-commit hook ran:

for FILE in $(git diff --cached --name-only)
do
        clang-format -i -style=file $FILE
	git add $FILE
done

[e10harvey]

@iyamazaki, Using this branch built with LayoutRight=ON and LayoutLeft=OFF shows:

$ ./KokkosKernels_sparse_serial --gtest_filter=*sptrsv*
Note: Google Test filter = *sptrsv*
[==========] Running 8 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 8 tests from serial
[ RUN      ] serial.sparse_sptrsv_double_int_int_TestExecSpace
Supernode Tri Solve SUCCESS
SUPERNODAL_DAG
Supernode Tri Solve SUCCESS
SUPERNODAL_DAG
[       OK ] serial.sparse_sptrsv_double_int_int_TestExecSpace (1 ms)
[ RUN      ] serial.sparse_sptrsv_double_int_size_t_TestExecSpace
Supernode Tri Solve SUCCESS
SUPERNODAL_DAG
Supernode Tri Solve SUCCESS
SUPERNODAL_DAG
[       OK ] serial.sparse_sptrsv_double_int_size_t_TestExecSpace (2 ms)
[ RUN      ] serial.sparse_sptrsv_float_int_int_TestExecSpace
Supernode Tri Solve SUCCESS
SUPERNODAL_DAG
Supernode Tri Solve SUCCESS
SUPERNODAL_DAG
[       OK ] serial.sparse_sptrsv_float_int_int_TestExecSpace (1 ms)
[ RUN      ] serial.sparse_sptrsv_float_int_size_t_TestExecSpace
Supernode Tri Solve SUCCESS
SUPERNODAL_DAG
Supernode Tri Solve SUCCESS
SUPERNODAL_DAG
[       OK ] serial.sparse_sptrsv_float_int_size_t_TestExecSpace (1 ms)
[ RUN      ] serial.sparse_sptrsv_kokkos_complex_double_int_int_TestExecSpace
Supernode Tri Solve SUCCESS
SUPERNODAL_DAG
Supernode Tri Solve SUCCESS
SUPERNODAL_DAG
[       OK ] serial.sparse_sptrsv_kokkos_complex_double_int_int_TestExecSpace (1 ms)
[ RUN      ] serial.sparse_sptrsv_kokkos_complex_double_int_size_t_TestExecSpace
Supernode Tri Solve SUCCESS
SUPERNODAL_DAG
Supernode Tri Solve SUCCESS
SUPERNODAL_DAG
[       OK ] serial.sparse_sptrsv_kokkos_complex_double_int_size_t_TestExecSpace (1 ms)
[ RUN      ] serial.sparse_sptrsv_kokkos_complex_float_int_int_TestExecSpace
Supernode Tri Solve SUCCESS
SUPERNODAL_DAG
Supernode Tri Solve SUCCESS
SUPERNODAL_DAG
[       OK ] serial.sparse_sptrsv_kokkos_complex_float_int_int_TestExecSpace (1 ms)
[ RUN      ] serial.sparse_sptrsv_kokkos_complex_float_int_size_t_TestExecSpace
Supernode Tri Solve SUCCESS
SUPERNODAL_DAG
Supernode Tri Solve SUCCESS
SUPERNODAL_DAG
[       OK ] serial.sparse_sptrsv_kokkos_complex_float_int_size_t_TestExecSpace (1 ms)
[----------] 8 tests from serial (9 ms total)

[----------] Global test environment tear-down
[==========] 8 tests from 1 test case ran. (9 ms total)
[  PASSED  ] 8 tests.

[iyamazaki]

Thank you, @e10harvey. Yes, this is because the unit-test takes each column as supernode, and we don't need to specify the matrix is upper/lower, for instance. I will modify the unit test to have a non-trivial supernode.

[e10harvey]

@iyamazaki, should we merge this to fix the link errors?

[iyamazaki]

Now, we require LayoutLeft. So, we are okay? And, this may fix the link errors, but we need more to support LayoutRight.

[e10harvey]

I think this should be merged in case someone wants to start working on supporting LayoutRight; this will put them a step closer.

[iyamazaki]

Thank you @e10harvey. I am running a test locally, just to make sure!! Right now, if we try to enable SUPERNODAL_SPTRSV without LayoutLeft, we should see an error message. But, I wonder if we can add comments somewhere in the codes, saying we only support default_layout = LayoutLeft.. I may forget..

[e10harvey]

Right now, if we try to enable SUPERNODAL_SPTRSV without LayoutLeft, we should see an error message. But, I wonder if we can add comments somewhere in the codes, saying we only support default_layout = LayoutLeft.. I may forget..

I think the CMake check you added via kokkos@88cb062 is clear but a comment would be nice.

[iyamazaki]

Hi, @e10harvey. My quick local unit-test passed. Do you want to add the comments before merging this?

[e10harvey]

No. I am ready to merge.