Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two bug fixes on the schedule mechanism for requeueing #201

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

anero
Copy link
Contributor

@anero anero commented Dec 16, 2024

This PR fixes a couple of bugs found while testing the new schedule mechanism for putting back jobs on the queue:

  • Fixed a bug on how the maximum retry period is calculated from strategies in StrategyCollection
  • Fixed how the call to re-queue a job is made, to only include the "queue:" prefix if needed (when performing a direct lpush on redis). This otherwise caused new queues to be created with the extra prefix.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.71%. Comparing base (a15db1b) to head (7465a83).

Files with missing lines Patch % Lines
lib/sidekiq/throttled/strategy.rb 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          19       19           
  Lines         466      468    +2     
  Branches       77       77           
=======================================
+ Hits          460      462    +2     
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mnovelo
Copy link
Contributor

mnovelo commented Dec 16, 2024

@anero created a PR with a minor suggestion controlshift#6

@anero
Copy link
Contributor Author

anero commented Dec 18, 2024

@mnovelo Thank you! I merged your changes.

@ixti This is ready for reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants