Merge pull request civicrm#11054 from omarabuhussein/CRM-21195-improv…

…e-menu-item-icons-markup CRM-21195: Improving menu item icon markup
ixiam · Jan 10, 2018 · 70aa20c · 70aa20c
2 parents 514ef52 + e5dd49b
commit 70aa20c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CRM/Core/BAO/Navigation.php b/CRM/Core/BAO/Navigation.php
@@ -528,7 +528,7 @@ public static function getMenuName(&$value, &$skipMenuItems) {
     }
 
     if (!empty($value['attributes']['icon'])) {
-      $menuIcon = sprintf('<span class="%s"></span>&nbsp;', $value['attributes']['icon']);
+      $menuIcon = sprintf('<i class="%s"></i>', $value['attributes']['icon']);
       $name = $menuIcon . $name;
     }
 

diff --git a/css/civicrmNavigation.css b/css/civicrmNavigation.css
@@ -120,6 +120,9 @@ img.menu-item-arrow{
   right: 4px;
   top: 8px;
 }
+#civicrm-menu i {
+  margin-right: 5px;
+}
 li.menu-separator{
   border-bottom: 1px solid #000;
   font-size: 0; /* for ie */