Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lisp nesting in jsonian-no-so-long-mode #28

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Conversation

Walheimat
Copy link
Contributor

Adds new variable jsonian--so-long-predicate that stores the original function stored in so-long-predicate before setting it to a lambda (which now calls the stored old function).

Calling jsonian-unload-function reinstates the old function.

The original implementation leads to "Lisp nesting exceeds max-lisp-eval-depth" on every call to the predicate function.

Adds new variable `jsonian--so-long-predicate` that stores the
original function stored in `so-long-predicate` before setting it to a
lambda (which now calls the stored old function).

Calling `jsonian-unload-function` reinstates the old function.
@iwahbe iwahbe self-requested a review July 5, 2022 21:55
Copy link
Owner

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this fix.

@iwahbe iwahbe merged commit ad861d1 into iwahbe:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants