Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed codol LOD #168

Merged
merged 4 commits into from
Dec 8, 2024
Merged

fixed codol LOD #168

merged 4 commits into from
Dec 8, 2024

Conversation

nucleur16
Copy link
Contributor

What does this PR do?

This PR fixes the LOD issues on CoDOL maps

How does this PR change IW4x's behaviour?

The LODs which formerly looked liked mashed up polygons now resemble the models of which they truly are.
Ex: Trees on Fav & Estate Tropical, Barrels on Rust Long, etc

Anything else we should know?

Idk, it's one line.

Did you check all the boxes?

yes
Not an open issue but a well known one
It's a copy paste of someone else's code with the vars in memcpy changed.
one commit

@Rackover
Copy link
Contributor

Rackover commented Dec 3, 2024

Rust long and Storm spring still look cooked, so I suppose there's more to this than this PR and that we'll need to come back to it at a later point
image
image
image

But LODs on Fav Tropical and Estate Tropical look much better 😃
image
image

I think it would be really cool if we could replace all those + 12 offsets and so on by a real struct description of the rawfile model format, would probably help with this kind of oversight

@nucleur16
Copy link
Contributor Author

Yea the cars are a problem also on bog... I too am curious about it. Guess I'll just printf all the stuff on modifyasset and compare iw4 modelsurfs to OL ones again. I assumed the data structure is a bit different to iw4 so the offset is coping with that.

@Rackover Rackover merged commit c7a804c into iw4x:develop Dec 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants