Discard non-existent dvar #153
Conversation
The dvar `aim_lockon_pitch_strength` does not exist. Whether it should exist is something to consider, and if so, it should then be registered appropriately. This commit removes all references to it and uses `aim_lockon_strength` as the scale/strength factor when calculating the pitch turn rate. This aligns with the behavior in the Xbox 360 version of the game.
|
Good catch, yeah IW4x controller support was pasted from T5 and not IW4 Xbox so mistakes like this happened. |
This commit replaces the `AimAssist_Lerp` function with `std::lerp` as it is part of the C++ STL which may provide performance benefits.
|
Is there a reason why we would want to discard this variable? It allows managing the pitch correction separately from the yaw correction. Sure, it might not exist in IW4 Xbox. But IW4x contains a lot of other stuff that does not exist on IW4 Xbox... ! I'm not sure how this is relevant. Could you describe in details what problem this PR intends to solve? 🤔 |
|
This PR will bring parity to how the lock-on turn rates are calculated on the Xbox 360 version of the game using a single dvar ( While you're correct that this does not need to be followed just because it's done that way on the Xbox 360 version, if a separate dvar such as
|
|
I understand better now! 🙂 Thansk for the explanations |
…ription This commit restores `aim_lockon_pitch_strength` and properly registers the dvar. It also updates the description of `aim_lockon_strength` (by hooking the dvar registration) to clarify that it now solely serves as the scale/strength factor for the yaw turn rate.
|
Tested and works |
What does this PR do?
This commit removes all references to it and uses
aim_lockon_strengthas the scale/strength factor when calculating the lock-on pitch turn rate. This aligns with the behavior in the Xbox 360 version of the game.How does this PR change IW4x's behaviour?
I am unsure as I do not have a controller to test.
Anything else we should know?
The dvar
aim_lockon_pitch_strengthexists in T5 (I believe from recollection). Whether there should be seperate dvars for lock-on pitch and yaw strength is another question, and if so, the dvars should then be registered properly.