-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isin extension #5762
Isin extension #5762
Conversation
b23abde
to
d7f8f1e
Compare
Hi @pillarxyz, could you tell me what method you use for committing things? is it the terminal or through your IDE |
I'm using pycharm with ivy conda environment, and using git in the terminal |
@abdrahmandiab I think that the tensorflow implementation works fine now, although a particular example keeps failing for some reason even though when I try the function in the python console with the inputs in the examples it delivers the expected results. I think we should probably just merge this if you see fit as everything else except for that argument works perfectly and I will revisit the tensorflow implementation once I figure out a way. Thanks again for your patience with me and helpful advice |
hi @pillarxyz, So I think before we give up and merge it, if you could edit the data generation to ensure that the generated arrays contain unique elements, I think this might stop the failing examples. My initial idea to do this is to use something like...
And of course let me know if you need any help with this. You can add me on Discord at |
Aha, well in this case where you are using it from the terminal, please refrain from using |
Hi @pillarxyz, Thanks so much for your hard work, and good luck with the rest of your application process! <3 |
Thanks alot for the help, I've learnt alot about the project thanks to you <3 |
Co-authored-by: Abdelrahman Diab <37490334+abdrahmandiab@users.noreply.github.com>
#5716
added most backend implementations there is only problem with tensorflow I'm still trying to solve since it doesnt have the function isin, once I'm able to do that I will add tests