-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moveaxis extension #5609
moveaxis extension #5609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes required but ready to merge otherwise. Is an issue open for this that I can perhaps link it to?
ivy/array/extensions.py
Outdated
>>> print(x.moveaxis(-1, 0).shape) | ||
(5, 3, 4) | ||
""" | ||
return ivy.flatten( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is supposed to be ivy.moveaxis
ivy/container/extensions.py
Outdated
With one :class:`ivy.Container` input: | ||
|
||
>>> x = ivy.Container(a=ivy.zeros((3, 4, 5)), b=ivy.zeros((2,7,6))) | ||
>>> ivy.static_moveaxis(x, 0, -1).shape |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ivy.Container.static_moveaxis
here
ivy/container/extensions.py
Outdated
With one :class:`ivy.Container` input: | ||
|
||
>>> x = ivy.Container(a=ivy.zeros((3, 4, 5)), b=ivy.zeros((2,7,6))) | ||
>>> ivy.moveaxis(x, 0, -1).shape |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x.moveaxis(0,-1).shape here
Changes made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
No description provided.