Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moveaxis extension #5609

Merged
merged 8 commits into from
Oct 12, 2022
Merged

moveaxis extension #5609

merged 8 commits into from
Oct 12, 2022

Conversation

nassimberrada
Copy link
Contributor

No description provided.

Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes required but ready to merge otherwise. Is an issue open for this that I can perhaps link it to?

>>> print(x.moveaxis(-1, 0).shape)
(5, 3, 4)
"""
return ivy.flatten(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supposed to be ivy.moveaxis

With one :class:`ivy.Container` input:

>>> x = ivy.Container(a=ivy.zeros((3, 4, 5)), b=ivy.zeros((2,7,6)))
>>> ivy.static_moveaxis(x, 0, -1).shape
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ivy.Container.static_moveaxis here

With one :class:`ivy.Container` input:

>>> x = ivy.Container(a=ivy.zeros((3, 4, 5)), b=ivy.zeros((2,7,6)))
>>> ivy.moveaxis(x, 0, -1).shape
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x.moveaxis(0,-1).shape here

@nassimberrada
Copy link
Contributor Author

Changes made.
Here's the issue #5614

@ivy-leaves ivy-leaves added Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy Functional API Function Reformatting Reformat all Ivy functions in accordance with the latest coding style in the contributor guide labels Oct 12, 2022
@Ishticode Ishticode linked an issue Oct 12, 2022 that may be closed by this pull request
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@Ishticode Ishticode merged commit dadff1d into ivy-llc:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Function Reformatting Reformat all Ivy functions in accordance with the latest coding style in the contributor guide Ivy Functional API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

moveaxis
3 participants