Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: experimental layer_norm functions #26478

Closed
wants to merge 1 commit into from
Closed

Conversation

uuzall
Copy link

@uuzall uuzall commented Oct 2, 2023

PR Description

This PR adds the experimental layer_norm functions. The layer_norm functions have been added to the ivy experimental, and the torch experimental files. The tests have also been added.

Related Issue

Close #26362

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@uuzall uuzall changed the title Extend Ivy Functional API: layer_norm functions feat: experimental layer_norm functions Oct 2, 2023
@ivy-leaves ivy-leaves added Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API labels Oct 2, 2023
@uuzall
Copy link
Author

uuzall commented Oct 26, 2023

@MahmoudAshraf97 Hello, could you please review this PR.

@MahmoudAshraf97
Copy link
Contributor

Hello and thanks for your contribution, since layer_norm already exists in our functional API I'll have to close this PR unfortunately

@uuzall
Copy link
Author

uuzall commented Oct 30, 2023

Hello @MahmoudAshraf97, this PR is for the experimental functional API as listed in Issue #3856. I double-checked, and the experimental API does not have layer_norm added yet.

@MahmoudAshraf97
Copy link
Contributor

It exists in the stable API, not the experimental

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

layer_norm
3 participants