Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added average function the backend APIs #26009

Closed
wants to merge 6 commits into from

Conversation

akosua00
Copy link
Contributor

@akosua00 akosua00 commented Sep 24, 2023

PR Description

Related Issue

Close #23107

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials:

average #23107

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.

@akosua00 akosua00 changed the title Main average Sep 24, 2023
@akosua00 akosua00 changed the title average feat: Added average function the backend APIs Sep 24, 2023
@ivy-leaves ivy-leaves added PaddlePaddle Backend Developing the Paddle Paddle Backend. NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist Ivy Functional API Ivy API Experimental Run CI for testing API experimental/New feature or request labels Sep 24, 2023
@ivy-seed ivy-seed assigned YushaArif99 and unassigned p3jitnath Oct 9, 2023
Copy link
Contributor

@YushaArif99 YushaArif99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @akosua00

Apologies for the delay in review. Since the person originally assigned to your PR has left the team, I'll now be reviewing the PR instead. As a first step, could you kindly resolve all the merge conflicts in the PR? Thanks! 🙂

Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @akosua00
Thanks for the PR
This functional implementation would require an accompanying test. Could you please add the test similar to other experimental functions under ivy_tests/test_ivy/test_functional/test_experimental
Please request a review when done. Thanks :)

@Ishticode
Copy link
Contributor

closing this due to lack of activity with changes requested remaining unresolved. Please feel free to reopen if you would like to continue working on this.

@Ishticode Ishticode closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist Paddle Paddle Backend PaddlePaddle Backend Developing the Paddle Paddle Backend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

average
7 participants