Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

percentile #19260 #19589

Closed
wants to merge 11 commits into from
Closed

percentile #19260 #19589

wants to merge 11 commits into from

Conversation

alrizkipascar
Copy link
Contributor

Close #19260

=====Notes=====
since paddle and torch does not have percentile function, I am just using quantile from each framework since they have same purpose.

@ivy-leaves ivy-leaves added Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request PaddlePaddle Backend Developing the Paddle Paddle Backend. labels Jul 18, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@MahmoudAshraf97 MahmoudAshraf97 removed their assignment Aug 6, 2023
Copy link
Contributor

@rishabgit rishabgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alrizkipascar! Thanks a lot for working on this 😄 It looks like the tests are failing, and it's throwing fixture 'ground_truth_backend' not found, could you please look into it?

Here's a quick way to run the tests on local before pushing the changes -

pytest /workspaces/ivy/ivy_tests/test_ivy/test_functional/test_experimental/test_core/test_statistical.py::test_percentile

Feel free to re-request review after making these changes, thanks! 😄

@alrizkipascar
Copy link
Contributor Author

Hi @alrizkipascar! Thanks a lot for working on this 😄 It looks like the tests are failing, and it's throwing fixture 'ground_truth_backend' not found, could you please look into it?

Here's a quick way to run the tests on local before pushing the changes -

pytest /workspaces/ivy/ivy_tests/test_ivy/test_functional/test_experimental/test_core/test_statistical.py::test_percentile

Feel free to re-request review after making these changes, thanks! 😄

Okay I will try find the issues

@rishabgit
Copy link
Contributor

Hi @alrizkipascar! Thanks a lot for working on this 😄 It looks like the tests are failing, and it's throwing fixture 'ground_truth_backend' not found, could you please look into it?
Here's a quick way to run the tests on local before pushing the changes -

pytest /workspaces/ivy/ivy_tests/test_ivy/test_functional/test_experimental/test_core/test_statistical.py::test_percentile

Feel free to re-request review after making these changes, thanks! 😄

Okay I will try find the issues

Thanks! I'll suggest starting with pulling the latest updates from ivy. There have been tons of changes in the testing pipeline recently. Good luck! 😄

@ivy-seed
Copy link

ivy-seed commented Oct 2, 2023

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

@ivy-seed ivy-seed added the Stale label Oct 2, 2023
@ivy-seed ivy-seed closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API PaddlePaddle Backend Developing the Paddle Paddle Backend. Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

percentile
5 participants