EHN : Adding searchsorted n jax devicearray.py #18980
Conversation
ivy-leaves
added
the
JAX Frontend
|
Hey @MuhammadNizamani! Thanks for contributing! The tests seem to be passing locally, however could you please update the name of the test function so that it references jax like the others? this for consistency's sake, also there has been some updates to the file paths recently, could you please fix the merge conflicts? Other than that the PR looks healthy! Thanks! :) |
|
@danielmunioz on it |
|
@danielmunioz please review this |
|
Hey @MuhammadNizamani! Yeah, as stated previously the tests seem to be passing locally, but could you please fix the merge errors and add "array" to the to the test name like the others? Other than that it looks good to me! :) |
|
@danielmunioz on it |
|
@danielmunioz I am done with the changes that you asked for please review my PR. |
|
Hey @MuhammadNizamani! All tests seem to be passing locally! LGTM, Merging now! Thanks! :) |
Closed #18979