Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added lgamma to tensorflow frontend, backend implementation missing #18292

Closed
wants to merge 2 commits into from
Closed

added lgamma to tensorflow frontend, backend implementation missing #18292

wants to merge 2 commits into from

Conversation

marccgrau
Copy link
Contributor

Close #18234

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Jul 4, 2023
hello-fri-end
hello-fri-end suggested changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@hello-fri-end hello-fri-end left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just requested some changes. Please feel free to request another review when you are done :)

ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py Outdated Show resolved Hide resolved
@hello-fri-end
Copy link
Contributor

Hey @marccgrau! Looks like we don't have an ivy.lgamma function yet. In this case, you can implement it as a composition of other functions in the frontend unless the implementation takes more than a few lines in which case you should first implement the lgamma function in the functional API. Take a look at https://unify.ai/docs/ivy/overview/contributing/open_tasks.html for more details. Thanks :)

@marccgrau @hello-fri-end
Update ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py
2ff5408 
Co-authored-by: Anwaar Khalid <shahanwaar.khalid8@gmail.com>
@marccgrau
Copy link
Contributor Author

Hi @hello-fri-end
Thanks for the review! I think a compositional implementation is not feasible as the gamma function is missing in ivy.
I opened a new issue (#18985) to add ivy.lgamma to the functional API. Several implementations in the native backends are available.

pending #18985

@hello-fri-end
Copy link
Contributor

Hi @hello-fri-end Thanks for the review! I think a compositional implementation is not feasible as the gamma function is missing in ivy. I opened a new issue (#18985) to add ivy.lgamma to the functional API. Several implementations in the native backends are available.

pending #18985

Sounds good @marccgrau ! Thanks for taking the initiative of adding lgamma to the functional API 🚀

@ivy-seed ivy-seed added the Stale label Jul 19, 2023
@ivy-seed
Copy link

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

@marccgrau
Copy link
Contributor Author

Hi @hello-fri-end, ivy.lgamma is now included in the backend (#19152). Thus, I assume the frontend function could now be included.

@hello-fri-end
Copy link
Contributor

Hi @hello-fri-end, ivy.lgamma is now included in the backend (#19152). Thus, I assume the frontend function could now be included.

Awesome! Again, thanks for taking the initiative of adding it in ivy 🚀

Would you please sync this PR with master so that the changes are reflected here as well?

@ivy-seed
Copy link

This PR has been closed because it has been marked as stale for more than 7 days with no activity.

@ivy-seed ivy-seed closed this Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hello-fri-end hello-fri-end Awaiting requested review from hello-fri-end

Assignees

@hello-fri-end hello-fri-end

Labels
Stale TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lgamma
4 participants
@marccgrau @hello-fri-end @ivy-seed @ivy-leaves