L1 normalization added.

[Suraj520]

Added L1 normalization and migrated it to experimental.
Closes #15824

[zaeemansari70]

Hi @Suraj520,
I've seen you are still implementing the function in the PR,
kindly do request a review by commenting on the PR once you are done! 🙂

[Suraj520]

Hi @Suraj520, I've seen you are still implementing the function in the PR, kindly do request a review by commenting on the PR once you are done! slightly_smiling_face

Hi @zaeemansari70 : I'm not implementing anything as of now. Can you please review 😃

[zaeemansari70]

@Suraj520 , as this is a fundamental function this has to be a primary implementation which means it has to be implemented in all the backends separately, also you have to add the tests for the function as well, I'd suggest you to see the docs for this. https://lets-unify.ai/docs/ivy/overview/deep_dive/function_types.html
One more thing, your PR also not linked to an issue, kindly link the PR to the issue as well 🙂
Thanks! 🙂

[Suraj520]

@Suraj520 , as this is a fundamental function this has to be a primary implementation which means it has to be implemented in all the backends separately, also you have to add the tests for the function as well, I'd suggest you to see the docs for this. https://lets-unify.ai/docs/ivy/overview/deep_dive/function_types.html One more thing, your PR also not linked to an issue, kindly link the PR to the issue as well slightly_smiling_face Thanks! slightly_smiling_face 😄

Sure, I will check the deep-dive again. I'll try to update you on this by weekend.

[Suraj520]

@zaeemansari70 - I have implemented L1 normalization across all backends, Migrated it to experimental and written the unit tests. Kindly review 😄

[zaeemansari70]

Awesome @Suraj520 !

I've requested some more changes 🙂

1. As this is a backend implementation, you should also add the array and container instance methods, kindly add those.
2. Please resolve the merge conflicts too 🙂

Thanks! 🙂

[Suraj520]

Awesome @Suraj520 !

I've requested some more changes slightly_smiling_face

1. As this is a backend implementation, you should also add the array and container instance methods, kindly add those.
2. Please resolve the merge conflicts too slightly_smiling_face

Thanks! slightly_smiling_face

Hey @zaeemansari70

I've resolved the merge conflicts but I am not sure how and where to add the array and container instance methods. Can you please elaborate upon how and where it should be implemented with a reference example ?

Thanks !

[zaeemansari70]

Hi @Suraj520 ,
So there is a folder known as data_classes inside ivy, the path is ivy/data_classes
You will see the array and container folders there, you have to add these in the experimental folder for the respective files, you'll get an idea how to add them by looking at other implementations.
It's fairly simple 🙂

[Suraj520]

Hi @Suraj520 , So there is a folder known as data_classes inside ivy, the path is ivy/data_classes You will see the array and container folders there, you have to add these in the experimental folder for the respective files, you'll get an idea how to add them by looking at other implementations. It's fairly simple slightly_smiling_face

@zaeemansari70 : Done ! Please review 😄

[zaeemansari70]

lgtm!
Thanks for contributing to Ivy! 🙂

[zaeemansari70]

@Suraj520
I am manually linking your PR to an issue, kindly do not forget to do this in the future.

[zaeemansari70]

One last change 🙂

[zaeemansari70]

Sorry I missed this, this should be called from experimental Ivy

[Suraj520]

Thanks for pointing this out ! Fixed it 😄 ! Kindly check

[Suraj520]

lgtm

@Suraj520 I am manually linking your PR to an issue, kindly do not forget to do this in the future.

Sure ! Noted 😊

[zaeemansari70]

As the tests are also passing, the changes lgtm! 👍

[Suraj520]

As the tests are also passing, the changes lgtm! +1

Thanks !