[FIX] Poor image quality after cropping

[diegolmello]

@ivpusic We talked about this at #754.

On iOS, we were cropping the image twice.
On Android, image size were default 200x200.

Thanks!

[keshamtravels]

Please merge this pull request asap and what i would need to do if i want to get latest changes in my app for this repo

[evaleirasclapps]

Merge please! I need this

[ivpusic]

@diegolmello merged and released https://github.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.21.2

[diegolmello]

@ivpusic Why haven't you accepted my PR? As this is a community, it would be nice to get my name as contributor (not just on the release).

[ivpusic]

I appologize for that @diegolmello, I did some small changes based on your fork in a seaparate branch, and pushed everything together to master

[evaleirasclapps]

When is going to be released to NPM??

[ivpusic]

it is already released in version 0.21.2

[evaleirasclapps]

This did not work for me, I added compressImageQuality: 1 and it's still compress the image TOO MUCH

[haseebnaseem]

The fix does does not work.

[haseebnaseem]

Did anyone solve this ? The fix works on iOS but not android

[SkariDamm]

I was facing the same problem on Android when using the device dimensions as crop dimensions options for ImagePicker.openCamera.

I was successful in retaining the full image quality by doing:

const image = await ImagePicker.openCamera({});
const croppedImage = await ImagePicker.openCropper({
    path: image.path,
    width: image.width,
    height: (image.width * 9) / 16
});

[Lowisoft]

Hi, the changes that were made in this pull request (for iOS) caused another issue where the image doesn't get resized to the given height and width prop as stated here: #843.

Undoing the changes of this pull request solves the issue. So, I think the code must be reversed or adapted in the next release.

[diegolmello]

This PR works in my case, because I don't pass width and height props.
It was resizing, cropping, compressing and resizing again.
It may cause issues if you pass width and height, as pointed out.

[Lowisoft]

Yes, but it's a pity that we can't use fixed width and height props after this PR (which is an essential part of cropping) and that there might be other people who will run into this issue too.

[diegolmello]

@Lowisoft Yeah 😢
If you find out a way to get compression and crop working for both cases (with and without width/height), please open a PR.

[Lowisoft]

@diegolmello Unfortunately, I am not very familiar with Swift.
Does the changed code (for iOS) only fix the double cropping? In fact, without these changes everything works as expected and I didn't notice that the double cropping or quality caused any problems on a real iOS device.