Update quantif in group, not layer, fixes #1820

ivmartel · Dec 4, 2024 · 131e84d · 131e84d
1 parent 0a21bba
commit 131e84d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/gui/drawLayer.js b/src/gui/drawLayer.js
@@ -801,9 +801,6 @@ export class DrawLayer {
    * @param {Annotation} annotation The annotation to update.
    */
   #updateAnnotationDraw(annotation) {
-    // update quantification after math shape update
-    annotation.updateQuantification();
-    // update draw if needed
     if (this.#removeAnnotationDraw(annotation)) {
       this.#addAnnotationDraw(annotation, true);
     }

diff --git a/src/image/annotationGroup.js b/src/image/annotationGroup.js
@@ -154,6 +154,12 @@ export class AnnotationGroup {
   update(annotation, propKeys) {
     const index = this.#list.findIndex((item) => item.id === annotation.id);
     if (index !== -1) {
+      // update quantification if needed
+      if (propKeys.includes('mathShape') ||
+        propKeys.includes('textExpr')) {
+        annotation.updateQuantification();
+      }
+      // update list
       this.#list[index] = annotation;
       /**
        * Annotation update event.