-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move atomic_ops libs into Requires.private #656
Conversation
Please rebase to fresh master and explain the difference from the previous PR I just merged. |
@@ -197,6 +198,7 @@ if (enable_threads) | |||
"with_libatomic_ops and without_libatomic_ops are mutually exclusive") | |||
endif() | |||
set(ATOMIC_OPS_LIBS "-latomic_ops") | |||
set(ATOMIC_OPS_PC "atomic_ops") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set ATOMIC_OPS_LIBS using value of ATOMIC_OPS_PC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, update comment "ATOMIC_OPS_LIBS, PACKAGE_VERSION are defined above" below
@@ -1207,7 +1207,9 @@ AS_IF([test x"$with_libatomic_ops" != xno], | |||
[AS_IF([test x"$with_libatomic_ops" != xnone -a x"$THREADS" != xnone], | |||
[AC_MSG_RESULT([external]) | |||
ATOMIC_OPS_LIBS="-latomic_ops" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Define ATOMIC_OPS_LIBS based on ATOMIC_OPS_PC value.
AC_SUBST([ATOMIC_OPS_LIBS])], | ||
ATOMIC_OPS_PC="atomic_ops" | ||
AC_SUBST([ATOMIC_OPS_LIBS]) | ||
AC_SUBST([ATOMIC_OPS_PC])], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also define ATOMIC_OPS_PC="" below (for internal "internal" case)
I suddenly realized a problem. Maybe we should leave it into |
Although, 7.1 or 7.2 is not hard-coded in bdwgc source. I agree that we could leave this change for the future - I will create the relevant issue and close this PR. |
Acturally, bdwgc it self may requires atomic_ops, but it does not require downstream packages (like guile) requires atomic_ops. So I would suggest that move
@ATOMIC_OPS_LIBS@
intoRequires.private
, so that won't confuse downstream packages, especially when performing check.https://people.freedesktop.org/~dbn/pkg-config-guide.html#faq
So I think, move
atomic_ops
is a more appropriate solution.