Both working kotlinx.serialization and gson serialization. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hovi
force-pushed
the
kolinx-serialization
branch
from
05fdec4 to
bc36290
Compare
hovi
force-pushed
the
kolinx-serialization
branch
from
b8c73ca to
943660c
Compare
hovi
force-pushed
the
kolinx-serialization
branch
from
943660c to
6779c67
Compare
PremekPaska
reviewed
Jul 20, 2021
Comment on lines
+8
to
17
| @SerialName("Id") | ||
| override val id: String, | ||
| @SerialName("Position") | ||
| override val position: Vec3, | ||
| @SerialName("OrientationForward") | ||
| override val orientationForward: Vec3, | ||
| @SerialName("OrientationUp") | ||
| override val orientationUp: Vec3, | ||
| @SerialName("BlockType") | ||
| val blockType: String, |
There was a problem hiding this comment.
Seems like quite high price for respecting the local coding style on each side. I didn't realize it could be a problem when using a serialization library that does not support this automatic capitalization :-/
There was a problem hiding this comment.
Yeah, more on that here:
Kotlin/kotlinx.serialization#33
PremekPaska
approved these changes
Jul 20, 2021
hovi
force-pushed
the
kolinx-serialization
branch
from
6779c67 to
bf9c321
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.