Use workaround for fetching streaming URLs #4037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YouTube appears to be A/B testing some new integrity checks. Adding the parameter "CgIQBg" to InnerTube player requests appears to workaround the problem See TeamNewPipe/NewPipeExtractor#1084
syeopite
commented
Aug 7, 2023
| @@ -55,8 +55,9 @@ def extract_video_info(video_id : String, proxy_region : String? = nil) | |||
| client_config = YoutubeAPI::ClientConfig.new(proxy_region: proxy_region) | |||
|
|
|||
| # Fetch data from the player endpoint | |||
| # 8AEB param is used to fetch YouTube stories | |||
There was a problem hiding this comment.
I think we can safely remove the 8AEB param since stories was entirely removed by YouTube back in late June
SamantazFox
approved these changes
Aug 7, 2023
|
Is there a difference with and without the padding bytes (%3D in base64)? |
|
Nevermind, NP uses the non-padded version, let's use that too. |
unixfox
approved these changes
Aug 7, 2023
|
For the record, I did integrate that change into the test instance the other day (before the weekend) and it sure does work. I was planning to make a PR, but thanks for doing it instead ^^ |
syeopite
added a commit
to syeopite/invidious
that referenced
this pull request
Aug 8, 2023
PR iv-org#4037 introduced a workaround around YouTube's new integrity checks on streaming URLs. However, the usage of this workaround prevents storyboard data from being returned by InnerTube. This commit fixes that by only using the workaround when calling try_fetch_streaming_data
12 tasks
This was referenced Aug 10, 2023
syeopite
added a commit
to syeopite/invidious
that referenced
this pull request
Sep 19, 2023
PR iv-org#4037 introduced a workaround around YouTube's new integrity checks on streaming URLs. However, the usage of this workaround prevents storyboard data from being returned by InnerTube. This commit fixes that by only using the workaround when calling try_fetch_streaming_data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4027
YouTube appears to be A/B testing some new integrity checks. Adding the parameter "CgIQBg" to InnerTube player requests appears to workaround the problem
See TeamNewPipe/NewPipeExtractor#1084