docker: allow to configure Invidious by env var #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invidious gained support to read its configuration from an env var instead of config file in e3c10d7. Unfortunately, Docker doesn't allow newline characters in env var values (see [0]) which means we can only provide a proper YAML config by using the inlined configuration in docker-compose.yml which, unfortunately, is tracked by Git. Once support for multiline env var values has been added to Docker, we should migrate and read the config from a .env file instead (which is not tracked by Git). [0]: docker/compose#3527
leonklingele
force-pushed
the
docker-env-config
branch
from
0d936de to
afe0f1f
Compare
|
Rebased. Please merge once CI is green @omarroth |
|
👍 |
|
This pull request has been automatically locked since there has not been any activity in it in the last 30 days. If you want to tell us about needed or wanted changes or if problems related to this code are discovered, feel free to open an issue or a new pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invidious gained support to read its configuration from an env var
instead of config file in e3c10d7.
Unfortunately, Docker doesn't allow newline characters in env var
values (see 0) which means we can only provide a proper YAML config
by using the inlined configuration in docker-compose.yml which,
unfortunately, is tracked by Git. Once support for multiline env var
values has been added to Docker, we should migrate and read the config
from a .env file instead (which is not tracked by Git).