Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Linux functions on any OS based on GNU libc #50

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Use Linux functions on any OS based on GNU libc #50

merged 1 commit into from
Sep 8, 2024

Conversation

pinotree
Copy link
Contributor

@pinotree pinotree commented Sep 8, 2024

GNU libc (glibc) provides the prototypes for all the xattr functions.

Hence, extend the Linux support to anything based on GNU libc. In case of failures, most likely the underlying xattr functions will need to be fixed, rather than pyxattr itself.

GNU libc (glibc) provides the prototypes for all the xattr functions.

Hence, extend the Linux support to anything based on GNU libc. In case
of failures, most likely the underlying xattr functions will need to
be fixed, rather than pyxattr itself.
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.75%. Comparing base (e0cfe36) to head (7bb5bc7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   78.75%   78.75%           
=======================================
  Files           1        1           
  Lines         480      480           
  Branches       78       78           
=======================================
  Hits          378      378           
  Misses         63       63           
  Partials       39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iustin
Copy link
Owner

iustin commented Sep 8, 2024

Thanks! This looks sane, so approving.

@iustin iustin merged commit 76f30b3 into iustin:main Sep 8, 2024
19 checks passed
@pinotree pinotree deleted the glibc branch September 8, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants