Update to nalgebra 0.33.0 and simba 0.9.0 #75
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nalgebra and simba had a handful of breaking changes in their most recent updates. This should upgrade num-dual to make it compatible. Specifically, the changes were
nalebgra::Allocator
generics into a generic associated type onAllocator::Buffer
. Majority of changes were in thisSupersetOf<f32>
as a necessary trait bound forComplexField
andRealField
SimdValue
, lanes changed from a static fn to a associated const.All tests seemed to pass, but let me know if there's any other issues. I'll be using it in my own project for the next week or so and will update this if I hit any bugs although I don't expect any.
Also, I'm not sure if the
Allocator
changes would result in any potential simplifying that coule be made... my changes are mostly just to get things working. Let me know if there's any areas that may be worth investigating as far as simplifying things go.