Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to nalgebra 0.33.0 and simba 0.9.0 #75

Merged
merged 4 commits into from
Jul 14, 2024

Conversation

contagon
Copy link
Contributor

@contagon contagon commented Jul 5, 2024

nalgebra and simba had a handful of breaking changes in their most recent updates. This should upgrade num-dual to make it compatible. Specifically, the changes were

  • Moving of type in nalebgra::Allocator generics into a generic associated type on Allocator::Buffer. Majority of changes were in this
  • simba added SupersetOf<f32> as a necessary trait bound for ComplexField and RealField
  • in SimdValue, lanes changed from a static fn to a associated const.

All tests seemed to pass, but let me know if there's any other issues. I'll be using it in my own project for the next week or so and will update this if I hit any bugs although I don't expect any.

Also, I'm not sure if the Allocator changes would result in any potential simplifying that coule be made... my changes are mostly just to get things working. Let me know if there's any areas that may be worth investigating as far as simplifying things go.

@g-bauer
Copy link
Contributor

g-bauer commented Jul 6, 2024

That looks great. I successfully ran the tests in FeOs based on this PR. 👍

Copy link
Contributor

@prehner prehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks! The changes in nalgebra make the code much more readable. I found two lines where we can get rid of the duplicate trait bounds.

src/derivative.rs Outdated Show resolved Hide resolved
src/derivative.rs Outdated Show resolved Hide resolved
@prehner prehner merged commit f4123e3 into itt-ustutt:master Jul 14, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants