Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization for invoices with multiple due dates failes on date conversion #10

Conversation

JannickWeisshaupt
Copy link

This PR just contains a test invoice to reproduce the bug. This is NOT a fix.
For the CII field SpecifiedTradePaymentTerms and transitivly its child DueDateDateTime more than one instance are allowed. In the conversion chain the DueDate is converted to a semicolon seperated list, e.g. 2023-02-03;2023-03-03 and then converted as whole to a date, which fails.

Jannick Weisshaupt added 2 commits April 5, 2023 09:55

Verified

This commit was signed with the committer’s verified signature.
xen0n WÁNG Xuěruì
…Invalid date "2023-02-03;2023-03-03" (Day must be two digits)
@bdewein
Copy link
Collaborator

bdewein commented Apr 11, 2023

Whereas CII syntax does indeed allow for multiple SpecifiedTradePaymentTerms, the EN 16931 (and CIUS XRechnung accordingly) restricts BT-9 "Payment due date" and BT-20 "Payment terms" to no more than one.
The usage note for BT-9 in the EN sais that for partial payments, BT-9 states the first net due date and that more complex payment terms are to be stated in BT-20.
Thus, the example invoice included is not a valid XRechnung and allowing the display of multiple due dates would contradict the restrictions of XRechnung and EN semantic models. The problem is that CEN schematron is missing a check on the cardinalities of the above mentioned CII paths (see ConnectingEurope/eInvoicing-EN16931#343).

@bdewein bdewein closed this Apr 11, 2023
@JannickWeisshaupt JannickWeisshaupt deleted the fix-visualization-for-multipe-due-dates branch April 13, 2023 19:07
@JannickWeisshaupt
Copy link
Author

Thanks a lot for the info and opening the related issue in the en16831 repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants