refactor(browse): compact character/myo visibility checks

itinerare · Sep 3, 2024 · 4da7dae · 4da7dae
1 parent 3d92eb4
commit 4da7dae
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/app/Http/Controllers/BrowseController.php b/app/Http/Controllers/BrowseController.php
@@ -334,9 +334,7 @@ public function getCharacters(Request $request) {
                 break;
         }
 
-        if (!Auth::check() || !Auth::user()->hasPower('manage_characters')) {
-            $query->visible();
-        }
+        $query->visible(Auth::user() ?? null);
 
         return view('browse.masterlist', [
             'isMyo'       => false,
@@ -465,9 +463,7 @@ public function getMyos(Request $request) {
                 break;
         }
 
-        if (!Auth::check() || !Auth::user()->hasPower('manage_characters')) {
-            $query->visible();
-        }
+        $query->visible(Auth::user() ?? null);
 
         return view('browse.myo_masterlist', [
             'isMyo'       => true,
@@ -676,9 +672,7 @@ public function getSublist(Request $request, $key) {
                 break;
         }
 
-        if (!Auth::check() || !Auth::user()->hasPower('manage_characters')) {
-            $query->visible();
-        }
+        $query->visible(Auth::user() ?? null);
 
         $subCategory = CharacterCategory::where('masterlist_sub_id', $sublist->id)->orderBy('character_categories.sort', 'DESC')->pluck('name', 'id')->toArray();
         if (!$subCategory) {