Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

自动关闭非主动打开的空白标签页,造成无法下载文本链接 #38

Closed
Cye3s opened this issue Mar 13, 2014 · 6 comments
Closed

自动关闭非主动打开的空白标签页,造成无法下载文本链接 #38

Cye3s opened this issue Mar 13, 2014 · 6 comments
Labels
bug #Done

Comments

@Cye3s
Copy link

Cye3s commented Mar 13, 2014

Fx 28+全新安装pre19
选中"自动关闭非主动打开的空白标签页"
选中以下文本

http://luci.subsignal.org/~jow/reghack/reghack.mips.elf

右键, 在新标签页中打开, 跳出保存窗口, 但点击确定后不能开始下载

如果不选择"自动关闭非主动打开的空白标签页", 则无此问题
@ithinc
Copy link
Owner

ithinc commented Mar 15, 2014

这个功能曾经好用过吗？还是在某个Fx版本之后才失效的？

@ithinc
Copy link
Owner

ithinc commented Mar 15, 2014

Last good nightly: 2012-10-22
First bad nightly: 2012-10-23

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1c3e4cb1f754&tochange=48502b61a63e

@ithinc
Copy link
Owner

ithinc commented Mar 15, 2014

Introduced by Bug 722995 – DownloadLastDir.jsm uses global Private Browsing state to make decisions.

@Cye3s
Copy link
Author

Cye3s commented Mar 15, 2014

这个没注意，Firefox版本更新太快，TU又有段时间没更新，我记得应该是从19.0后开始出现
之前都好用

@ithinc
Copy link
Owner

ithinc commented Mar 15, 2014

不打开Save As对话框，保存到默认位置是没问题的。

@ithinc
Copy link
Owner

ithinc commented Mar 16, 2014

Test cases:
1/ Open
2/ Save
3/ Save As (Save, Cancel)
4/ Cancel

ithinc added a commit that referenced this issue Mar 16, 2014
@ithinc
Fix removeUnintentionalBlank option (#36, #38)
233dd50
@ithinc ithinc added #Done and removed #Someday labels Mar 16, 2014
ithinc added a commit that referenced this issue Mar 20, 2014
@ithinc
Revert "Fix removeUnintentionalBlank option (#36, #38)"
0fa793c 
This reverts commit 233dd50.
ithinc added a commit that referenced this issue Mar 20, 2014
@ithinc
Fix removeUnintentionalBlank option (#36, #38, #43)
8402398
@ithinc ithinc closed this as completed Mar 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug #Done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ithinc @Cye3s