Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stylus template #164

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Conversation

yahsan2
Copy link
Contributor

@yahsan2 yahsan2 commented Nov 20, 2018

Summary

Proposed changes

This PR brings the following changes:

  • Add support for generating .styl (stylus) files;
  • Add a default .stly (stylus) template;
  • Add a demo .styl (stylus) file.

No dependencies were added or removed


Testing

  • I have added or updated tests that prove my fix is effective or that my feature works (if applicable)

How to test

  1. Checkout the branch;
  2. Run npm install;
  3. Run npm run build && node dist/cli.js './src/__tests__/fixtures/svg-icons/*.svg' -d demo -t styl --normalize --center-horizontally;
  4. Check if exit error is 0 (success);
  5. Check if demo/webfont.styl file was created.

Test configuration

  • Node.js version: v12.17.0;
  • NPM version: 6.14.4.

Checklist

  • I have added corresponding labels to this PR (like bug, enhancement...);
  • My commits follow the Conventional Commits 1.0 Guidelines;
  • My code follows the style guidelines of this project;
  • I have performed a self-review of my own code;
  • I have mapped technical debts found on my changes;
  • I have made corresponding changes to the documentation at 588a753;
  • My changes generate no new warnings or errors;

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jimmyandrade jimmyandrade changed the title add stylus template feat: add stylus template Sep 29, 2020
Copy link
Collaborator

@jimmyandrade jimmyandrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yahsan2 thanks for contributing

demo/webfont.styl Show resolved Hide resolved
demo/webfont.styl Show resolved Hide resolved
templates/template.styl.njk Show resolved Hide resolved
@jimmyandrade jimmyandrade merged commit 5eb7004 into itgalaxy:master Sep 29, 2020
Copy link
Collaborator

@jimmyandrade jimmyandrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and merged

demo/webfont.styl Show resolved Hide resolved
demo/webfont.styl Show resolved Hide resolved
templates/template.styl.njk Show resolved Hide resolved
@yahsan2
Copy link
Contributor Author

yahsan2 commented Sep 30, 2020

thank you for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants