Render flexible confusion matrices as expected #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
extension/src/plots/model/collect.ts
Outdated
|
|
||
| if (isMultiView) { | ||
| fields.unshift('rev') | ||
| return JSON.parse( |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
mattseddon
commented
Oct 5, 2022
|
|
||
| const data = getMultiSourceOutput() | ||
|
|
||
| export default data |
There was a problem hiding this comment.
[F] This uses the regular pattern if we want to include the multi-source plots in a new story then I should be able to wire them up pretty quickly.
sroy3
approved these changes
Oct 5, 2022
|
Code Climate has analyzed commit 1e26fa1 and detected 0 issues on this pull request. Too many changed lines in diff View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/2
main<- this <- #2531Closes #2516
The problem was that the revision field was not being updated by us before trying to render the plot as expected. In order to do that we have to combine the rev field with the filename in the underlying data (no change to the template for these ones).
Successfully rendering the plot then causes a separate issue which is addressed in #2531.
Screenshot:
Test project: https://github.com/dberenbaum/example-get-started/tree/flexible_plots (output copied as a new test fixture).
Note:
+337,296of the diff comes fromextension/src/test/fixtures/plotsDiff/multiSource.ts